Extend workaround for azure devops bad request response#1728
Extend workaround for azure devops bad request response#1728AbiSo wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The vcpkg did set a new api-key, because the azure devops response contains a different string. The change adapts the condition when to re-issue nuget command.
|
Hmm... Azure DevOps shouldn't be messing with inter-process communication like this; it will replace API keys and similar but only does so in console output that gets posted back, not in between processes. How did you test that this actually fixes the problem? |
|
Hi, we replaced the vcpgk.exe, with the patched one, and the build went back to normal.
As I mentioned, I am no expert when it comes to Azure Devops and vcpkg. Not sure if the content of the response is configurable.
We just observed that the content in the response had changed - why - dont know. but the patch solved our situation, and the binaries are cached again.
|
This works for local builds (developer-machines) as well as for azure devops pipeline builds. (We ensured that the pipeline use the patched vcpkg.exe) |
|
The problem with 'well I think this fixes the problem sometimes' without a concrete understanding of what's going on is that:
I guess I'm looking for an explanation of how we got here. |
|
Closing due to no response in 6 months. We need a demonstration that this actually fixes anything before we can proceed. |
Setting
Description
When I start cmake for my project it first starts to check the vcpkg-configuration, download and build whats needed. For each dependent package it creates a nuget package, which is uploaded to cache in azure devops. Recently that upload didn't work anymore. After some deep dive it turned out that the azure devops returns a different string in bad request response.
Previously it contained the string
for example "-ApiKey AzureDevOps". It has changed tofor example "-ApiKey api-key-removed".Checking the source of vcpkg.exe revealed a place in binarycaching.cpp that has a workaround to play nicely with azure devops. The PR extends the corresponding part in binarycaching.cpp.
Notes